6 Commits

Include renames

Author	SHA1	Message	Date
randy	b0576f3725	Make Measure's vertices draggable and deletable ... Drag: mousedown on a vertex circle calls event.preventDefault() (the documented way to opt a gesture out of MapLibre's own drag-to-pan), then a map-wide mousemove/mouseup follows the cursor and updates that point's coordinates live. Delete: clicking a vertex selects it (shown larger/yellow); Delete or Backspace removes it, guarded against eating a keystroke meant for an actual text input on the page. A vertex's own mousedown sets a one-shot flag so the same click doesn't also fall through to the generic map-click handler and add a brand new point on top of it.	2026-09-09 12:47:44 +02:00
randy	b5b91d0df5	Gate note-writing UI behind login ... Adding a note (either tool) always ended in a 401 for a logged-out viewer — the write-only affordance just wasn't hidden yet, unlike GpxPanelControl's own upload/new-folder buttons, which already are. NotesControl isn't added to the map at all when logged out (its whole purpose is writing); MeasureControl's "Save as note" button is hidden but the tool itself stays usable for plain measuring either way.	2026-09-09 12:44:52 +02:00
randy	aafb4cb4a0	Consolidate note-drawing into Measure; add edit/delete ... Measure already draws distance lines and area polygons by hand — a second click-to-draw UI in the notes tool (Point/Area mode, from the previous commit) duplicated that. Replaced it with a "Save as note" button on the Measure panel that saves whatever shape is currently drawn there; NotesControl goes back to being just a one-click point pin. Both share a single NoteSaveForm (notes.js) for the note-text + target-layer-file UI instead of two copies of it. gpx.js: the "lines" source now also renders a note-flagged LineString (dashed, popup-on-click) alongside the Polygon fill/outline from before — the plain track-line layer excludes category:"Note" features so a saved distance note doesn't also get the track hover-summary/ profile-panel treatment. Notes are now individually editable/deletable from their own popup (logged-in only): Edit swaps the popup content for an inline textarea, Delete confirms and removes. Both target the feature by a new client-generated properties.id rather than array position (new GpxStore#update_feature/#delete_feature, PUT/DELETE /api/gpx/notes), since neither array index nor the note's own text (the thing being edited) is a stable identifier. Verified live: Measure's Save button (disabled/enabled state, saves the exact on-screen shape), the popup's Edit/Delete buttons and inline edit form. Full test suite: 115 runs, 0 failures (new coverage for update_feature/delete_feature and the PUT/DELETE routes).	2026-09-09 11:39:36 +02:00
randy	64a85afe6a	Fix a filter-syntax warning found while investigating missing labels ... Mixing the legacy "$type" filter with an expression (["get", "role"]) in the same filter logs as unsupported in newer MapLibre. Modernized all three measure layer filters to expression syntax; the vertex circle layer's filter simplifies to just checking "role" (it's only ever set on Point features to begin with, so the geometry-type check was redundant once "role" was added). Found while trying to reproduce a report that per-segment distance labels don't show on a longer, several-point measurement -- couldn't reproduce it locally or against production itself (both showed labels correctly on a fresh page load), so this may be unrelated; still worth fixing on its own.	2026-09-08 00:39:02 +02:00
randy	24b6180c03	Fix overlapping Distance/Area text; label each segment's own length ... The measure panel's mode buttons sit inside a maplibregl-ctrl-group container (for the ruler button's own 29x29 sizing) — its global "button" rule reaches them too, clipping "Distance"/"Area" into a fixed 29px square with zero padding instead of sizing to fit the text. Fixed by upping specificity (".measure-panel .measure-panel__mode") rather than fighting the cascade with !important. In distance mode, each segment between two clicked points now shows its own length at its midpoint, not just the running total in the panel — a symbol layer keyed off the existing source, filtered apart from the vertex circles by a new "role" property. Verified both in a real browser (panel no longer overlaps; two 638m segments rendered and labeled correctly summing to the panel's 1.28km total).	2026-09-07 23:05:54 +02:00
randy	b6a9c1546e	Add a distance/area measuring tool ... A ruler button in the top-left control stack, matching NPS's own Area/Distance ruler. Click to add vertices; distance sums haversine segment lengths, area uses the spherical-excess polygon formula (same one turf.js's area() uses) rather than a flat shoelace, since a flat approximation drifts at park-boundary scale. SI units only (m/km, m²/km²) — no imperial toggle.	2026-09-07 22:15:08 +02:00